Graalians - Script Help

Graalians (https://www.graalians.com/forums/index.php)

- General Graal Discussion (https://www.graalians.com/forums/forumdisplay.php?f=2)

- - Script Help (https://www.graalians.com/forums/showthread.php?t=7064)

I have summed this up by doing this:

PHP Code:


		
			
function onPlayerTouchsMe(){
if (player.account in serveroptions.staff) {
setlevel2("futustia-bar.nw", 10.5, 44.5);
player.dir = 2;
}
else {
player.chat = "I am not staff. I cannot be in this bar.";
}
}

I have learned alot being around you guys <3

Lol whoops. My bad on that one :-)

Amazing what you can do with scripts. I made an NPC in a small staff room guarded by that staff only script. The NPC inside gives whoever touches it the default staff weapons.

Quote:

Posted by Shawn (Post 134498)

Amazing what you can do with scripts. I made an NPC in a small staff room guarded by that staff only script. The NPC inside gives whoever touches it the default staff weapons.

O_o thats not a good method. Players can memory edit level links to warp them anywhere. You should only add staff weapons via RC

I though't I'd be easier. I can always make the Control NPC add weapons to staff when they log in.

Quote:

Posted by Shawn (Post 134815)

I though't I'd be easier. I can always make the Control NPC add weapons to staff when they log in.

That'd be your best bet. Just list them in an array and add them to the staff members as they login.

PHP Code:


		
			
for (wep : this.staff_weps) {
  if (player.clientr.isStaff) player.addweapon(wep);
}

Obviously, you'll have to set up giving staff the clientr.isStaff flag so it knowns if to add weapons or not. You could always read from serveroptions.staff and check if their account is inside the list.

PHP Code:


		
			
temp.staff = serveroptions.staff.tokenize(",");
if (player.account in temp.staff || player.communityname in temp.staff) {
  player.clientr.isStaff = true;
}

And I don't want to be the one to nag, but you really need to learn how to style your code. You can read into decent styling techniques in this official forums thread by Skyld, and you can also use FP4's GS2 beautifier. Obviously, styling code is pretty much personal preference, but it makes it easier to read if you adapt to using a clean and readable style so other coders can look through it with ease. Other than that, good job. You're making progress.

I don't like indenting my code. Tried it in PHP, didn't make a difference to me. But I'll try from now on :)

Quote:

Posted by Emera (Post 134830)

PHP Code:


		
			
for (wep : this.staff_weps) {
  if (player.clientr.isStaff) player.addweapon(wep);
}

Don't ever do that. It's -really- important to assign wep as a temporary variable, right now it's not. It's also very important to name your variables logically instead of taking shortcuts in order to get the names as short as possible. You'll thank me for that last piece of advice in a year or two when you go back and look at your old code.

There's little to no reason to keep the weapon list stored in a permanent array, so I'd change that too to a temporary one.

I also hate that styling, but then again it comes down to personal preference in this case.

Correct way, with my personal touch to it:

PHP Code:


		
			
temp.listOfStaffWeapons = {
  "Weapon1",
  "Weapon2",
  "Weapon3"
}

for (temp.weaponName: temp.listOfStaffWeapons) {
  if (player.clientr.isStaff)
    player.addWeapon(temp.weaponName);
}

Quote:

Posted by Shawn (Post 135127)

I don't like indenting my code. Tried it in PHP, didn't make a difference to me. But I'll try from now on :)

Good luck getting anywhere on Graal as a programmer without using proper indenting and styling.

What difference does it make, other than making it pretty?

Quote:

Posted by Shawn (Post 135283)

What difference does it make, other than making it pretty?

Easier to refer back to
Can read without being easily thought scattered
Looks Neat
Programmers will hate you if you don't

Quote:

Posted by BboyEatsbacon (Post 135301)

Programmers will hate you if you don't

I could imagine Skyld raging at me or something O.o

Quote:

Posted by Shawn (Post 135307)

I could imagine Skyld raging at me or something O.o

Skyld wouldn't accept a script like that to be uploaded to begin with.

It's because I'm beginner and he expects something that comes from a pro.

Quote:

Posted by Shawn

It's because I'm beginner and he expects something that comes from a pro.

Actually it's because I'm not going to waste my time trying to make heads or tails of terribly formatted code, not because you are a beginner, but because it's just hard to read. If you format your code properly, it makes it easier for other people to understand, and as a result, we will be more willing to help you.

Quote:

Posted by Skyld (Post 136085)

Oh wow, it has an account here! I am surprised.